Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net::UnixListener: Consider exposing poll_accept() #2260

Closed
akshayknarayan opened this issue Feb 19, 2020 · 2 comments
Closed

net::UnixListener: Consider exposing poll_accept() #2260

akshayknarayan opened this issue Feb 19, 2020 · 2 comments
Labels
A-tokio Area: The main tokio crate C-feature-request Category: A feature request. M-net Module: tokio/net

Comments

@akshayknarayan
Copy link
Contributor

UnixListener::poll_accept() is currently pub(crate).

However, TcpListener::poll_accept() is pub as of this commit: 8a7e577#diff-a0e934bf38b64e9a75c741bff132d8adL129

The corresponding Incoming types do expose poll_accept(), but the UnixListener and TcpListener should perhaps be made consistent - i.e., either restore pub(crate) to TcpListener::poll_accept() or make UnixListener::poll_accept() pub.

@kleimkuhler
Copy link
Contributor

@akshayknarayan I believe this is "temporary" until Tokio no longer depends on mio-uds for UnixListener since it does not have a stable release. If so, I think this could made pub once Tokio depends on a newer version of mio.

@Darksonn Darksonn added A-tokio Area: The main tokio crate C-feature-request Category: A feature request. M-net Module: tokio/net labels Apr 29, 2020
@de-vri-es
Copy link
Contributor

This has been fixed by #2845 and #2880 :D

Not released yet, but this issue can probably be closed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tokio Area: The main tokio crate C-feature-request Category: A feature request. M-net Module: tokio/net
Projects
None yet
Development

No branches or pull requests

4 participants