Skip to content

trace: prepare tokio-trace for release #1051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 22, 2019
Merged

Conversation

hawkw
Copy link
Member

@hawkw hawkw commented Apr 15, 2019

This branch prepares tokio-trace for an 0.1 release on crates.io.

It also makes some last minute documentation improvements
(including fixing broken links in RustDoc).

@hawkw hawkw added tokio-trace C-maintenance Category: PRs that clean code up or issues documenting cleanup. labels Apr 15, 2019
@hawkw hawkw requested a review from carllerche April 15, 2019 21:55
@hawkw
Copy link
Member Author

hawkw commented Apr 17, 2019

Note: this build is only failing because the tokio-trace dependency on tokio-trace-core was changed to 0.2, which hasn't been published yet.

@carllerche
Copy link
Member

Check the azure pipelines configuration (I think in a template unless). There is a commit message tag you can use for this case. It will avoid pulling from crates.io.

Verified

This commit was signed with the committer’s verified signature.
hawkw Eliza Weisman
[ci-release]
@hawkw hawkw force-pushed the eliza/release-trace branch from 25e8e98 to e9c68d6 Compare April 22, 2019 18:03
hawkw added 3 commits April 22, 2019 11:06

Verified

This commit was signed with the committer’s verified signature.
hawkw Eliza Weisman
[ci-release]

Signed-off-by: Eliza Weisman <eliza@buoyant.io>

Verified

This commit was signed with the committer’s verified signature.
hawkw Eliza Weisman
[ci-release]

Signed-off-by: Eliza Weisman <eliza@buoyant.io>

Verified

This commit was signed with the committer’s verified signature.
hawkw Eliza Weisman
[ci release]

Signed-off-by: Eliza Weisman <eliza@buoyant.io>
@hawkw hawkw marked this pull request as ready for review April 22, 2019 18:58
@hawkw
Copy link
Member Author

hawkw commented Apr 22, 2019

@carllerche now that we've released tokio-trace-core 0.2, and I've wrapped up some final release prep, I think this is ready (pending CI). Let me know if I've missed anything!

@carllerche carllerche merged commit 3ebca76 into master Apr 22, 2019
@carllerche carllerche deleted the eliza/release-trace branch April 22, 2019 21:26
hawkw added a commit that referenced this pull request Jun 25, 2019
@Darksonn Darksonn added the M-tracing Tracing support in Tokio label Jul 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-maintenance Category: PRs that clean code up or issues documenting cleanup. M-tracing Tracing support in Tokio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants