Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no_std/sgx: deps: fix itertools features #781

Merged
merged 1 commit into from Dec 13, 2022
Merged

no_std/sgx: deps: fix itertools features #781

merged 1 commit into from Dec 13, 2022

Conversation

n-prat
Copy link
Contributor

@n-prat n-prat commented Dec 13, 2022

This improves prost(or rather prost-derive) when building in SGX environment.

Without this the dependencies are:

either v1.8.0
└── itertools v0.10.5
    └── prost-derive v0.11.2 (proc-macro)
        └── prost v0.11.3
            └── XXX v0.1.0 (/XXX) (*)

And "either" fails to build under no_std:
cargo no-std-check --manifest-path Cargo.toml:

error[E0463]: can't find crate for `std`
  --> /XXX/.cargo/registry/src/github.com-1ecc6299db9ec823/either-1.8.0/src/lib.rs:19:1
   |
19 | extern crate std;
   | ^^^^^^^^^^^^^^^^^ can't find crate
[...]

I also used the same features for prost-build for consistency, but this is not really required I guess?

This allows prost-derive to be built in SGX environment.

Without this the dependencies are:
either v1.8.0
└── itertools v0.10.5
    └── prost-derive v0.11.2 (proc-macro)
        └── prost v0.11.3
            └── XXX v0.1.0 (/XXX) (*)
And "either" fails to build under no_std:
`cargo no-std-check --manifest-path Cargo.toml`:

```
error[E0463]: can't find crate for `std`
  --> /home/pratn/.cargo/registry/src/github.com-1ecc6299db9ec823/either-1.8.0/src/lib.rs:19:1
   |
19 | extern crate std;
   | ^^^^^^^^^^^^^^^^^ can't find crate
[...]
```
@LucioFranco
Copy link
Member

Thanks!

@LucioFranco LucioFranco merged commit a7aac76 into tokio-rs:master Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants