Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(build): Ignore clippy warning derive_partial_eq_without_eq #775

Conversation

tottoto
Copy link
Contributor

@tottoto tottoto commented Dec 8, 2022

Ignores clippy warning derive_partial_eq_without_eq in generated codes to solve clippy warning easily in projects using prost-build.

@tottoto
Copy link
Contributor Author

tottoto commented Dec 8, 2022

The generated codes should be updated.

@tottoto
Copy link
Contributor Author

tottoto commented Dec 8, 2022

Updates generated codes. The minversions test fail might not be related to this pull request.

Copy link
Member

@LucioFranco LucioFranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@LucioFranco
Copy link
Member

Not sure why CI is failing :(

@LucioFranco
Copy link
Member

#776 removing that CI run

@LucioFranco LucioFranco merged commit d531ba7 into tokio-rs:master Dec 9, 2022
@tottoto tottoto deleted the ignore-clippy-warning-derive-partial-eq-without-eq branch December 9, 2022 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants