Expose from_str_name() for generated enums #774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
segfault87
force-pushed
the
create-enum-from-str-name
branch
3 times, most recently
from
bf13275
to
2336379
Compare
segfault87
force-pushed
the
create-enum-from-str-name
branch
from
2336379
to
1eeb6a4
Compare
LucioFranco
approved these changes
Dec 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi.
This PR enables
prost-buildcodegen to includefrom_str_name()for each generated enumerations.Currently there is no way to create Protobuf enums from names. Since Protobuf JSON format states enum value can be represented as string value, I think it is necessary when it comes to adding support for JSON serialization/deserialization.