Allow generated Message derive path to be changed
#729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LucioFranco
approved these changes
Oct 21, 2022
|
missing path for property type, ::prost::alloc, ::prost::bytes ? |
|
Yeah, we should cover those as well |
|
Here is the follow up PR #740 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a use case where I'm building a wrapper around
prost-buildin combination withprost-reflectto extract protobuf custom options and do some magic.However, since this wrapper, let's call it
my-build, will be used from a large number of different crates it would be ideal to have themy-corecrate re-exportprostto simplify upgrades down the line.In order to facilitate this use case I've added a simple configuration option which would allow me to change the default
#[derive(::prost::Message)]to#[derive(::my_crate::prost::Message)].Hopefully, it's a simple enough change that it won't be too controversial 馃槃
Please let me know if there's anything you'd like me to change.