Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tuple struct support #706

Merged
merged 2 commits into from Sep 28, 2022
Merged

Conversation

ldm0
Copy link
Contributor

@ldm0 ldm0 commented Aug 13, 2022

Fixes #56
Remove some(4) outdated TODOs by the way.

@ldm0 ldm0 marked this pull request as ready for review August 13, 2022 22:09
prost-derive/src/lib.rs Outdated Show resolved Hide resolved
@ldm0 ldm0 force-pushed the ldm_supports_tuple_struct branch from 60e2b4a to 6c8b678 Compare August 13, 2022 22:31
@ldm0 ldm0 force-pushed the ldm_supports_tuple_struct branch from 6c8b678 to 4d10896 Compare August 14, 2022 10:21
Copy link
Member

@LucioFranco LucioFranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay on review but I finally had some time to digest the macro code and this LGTM! Thanks!

@LucioFranco LucioFranco merged commit a1a3603 into tokio-rs:master Sep 28, 2022
@ldm0 ldm0 deleted the ldm_supports_tuple_struct branch October 12, 2022 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tuple structs with enumerations don't work
2 participants