Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[prost-build] avoid cmake dependency #646

Closed
nstinus opened this issue May 9, 2022 · 1 comment
Closed

[prost-build] avoid cmake dependency #646

nstinus opened this issue May 9, 2022 · 1 comment

Comments

@nstinus
Copy link

nstinus commented May 9, 2022

Today, prost-build tries to find protoc and if it fails, builds it from the vendored sources.
That adds the cmake dependency even though it may not be needed.

Could the default behavior be changed to:

  • look for protoc in PROTOC or PATH, then fail.
  • if vendored feature is enable, use this one only.

There is the PROTOC_NO_VENDOR env var but the cmake dep is still required.
On top of removing a dependency in some cases, it would also make clearer what is happening.

@LucioFranco
Copy link
Member

#657 fixes this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants