Bundled protoc only if the interpreter exists #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise on systems such as NixOS the prost-build attempts to execute the bundled protoc, hits a very obscure error about file not existing and exits, without trying the other options (such as the protoc from path, if it exists there).
LucioFranco
approved these changes
Jul 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise on systems such as NixOS the prost-build attempts to execute
the bundled protoc, hits a very obscure error about file not existing
and exits, without trying the other options (such as the protoc from
path, if it exists there).
This also happens to cover the musl case, which has its interpreters as
/lib/ld-musl-...instead, as well as various instances where glibc mightwant to bump the so version for its interpreter (has recently happened in
the past for x86_64 IIRC).