Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Currently, the console only supports TCP, is there a plan to support Unix Domain Socket? #296

Closed
quanweiZhou opened this issue Feb 25, 2022 · 7 comments · Fixed by #388
Closed

Currently, the console only supports TCP, is there a plan to support Unix Domain Socket? #296

quanweiZhou opened this issue Feb 25, 2022 · 7 comments · Fixed by #388

Comments

@quanweiZhou
Copy link

No description provided.

@hawkw
Copy link
Member

hawkw commented Feb 25, 2022

The console uses tonic as both the gRPC server (in the console-subscriber crate) and as the gRPC client (in the tokio-console command-line application). It looks like a PR to add Unix socket support in tonic was merged recently (hyperium/tonic#861), but I don't believe it has been released yet. Once that PR is part of an upstream release of tonic, it should be pretty straightforward to add UDS support to the console.

bIgBV pushed a commit to bIgBV/console that referenced this issue Mar 12, 2022
@hawkw
chore(console): prepare to release v0.1.2 (tokio-rs#293)
900a5c2 
<a name="0.1.2"></a>
## 0.1.2 (2022-02-18)

#### Bug Fixes

*  console-api dependencies to require 0.1.2 (tokio-rs#274) ([b95f683](b95f683), closes [tokio-rs#270](270))
*  missing histogram in task details (tokio-rs#296) ([884f4ec](884f4ec), closes [tokio-rs#296](296))
@Milo123459
Copy link
Contributor

A new version was released 3 days ago, I believe that Unix socket support is in that release. Could this be looked at?

@hawkw
Copy link
Member

hawkw commented Apr 8, 2022

Yes, once we merge #318, it should be pretty easy to add support for Unix sockets. I've been out of the office for the last four days, so I haven't had the time to take care of that until today.

@Milo123459
Copy link
Contributor

Cool! Glad to know it's hopefully getting implemented soon.

@quanweiZhou
Copy link
Author

@hawkw Currently the tonic 0.7 already supports UDS but the console doesn't seem to support UDS yet, am I missing something?

@Milo123459
Copy link
Contributor

Milo123459 commented Jun 5, 2022 •
edited

Any updates? #318 was merged.

@hawkw
Copy link
Member

hawkw commented Jun 5, 2022

I haven't had the time to work on this, but now that Tonic 0.7 is out, it should certainly be possible and (I imagine) fairly straightforward. I'd happily merge a PR if anyone is interested in working on one.

benesch added a commit to benesch/tokio-console that referenced this issue Dec 4, 2022
@benesch
feat(console): add support for Unix domain sockets
6864f06 
Add support for console connections that use Unix domain sockets rather
than TCP.

Fix tokio-rs#296.
benesch added a commit to benesch/tokio-console that referenced this issue Dec 4, 2022
@benesch
feat(console): add support for Unix domain sockets
41ece92 
Add support for console connections that use Unix domain sockets rather
than TCP.

Fix tokio-rs#296.
@benesch benesch mentioned this issue Dec 4, 2022
Merged
benesch added a commit to benesch/tokio-console that referenced this issue Dec 11, 2022
@benesch
feat(console): add support for Unix domain sockets
862cc4b 
Add support for console connections that use Unix domain sockets rather
than TCP.

Fix tokio-rs#296.
benesch added a commit to benesch/tokio-console that referenced this issue Dec 11, 2022
@benesch
feat(console): add support for Unix domain sockets
d93e724 
Add support for console connections that use Unix domain sockets rather
than TCP.

Fix tokio-rs#296.
benesch added a commit to benesch/tokio-console that referenced this issue Dec 11, 2022
@benesch
feat(console): add support for Unix domain sockets
560e0c4 
Add support for console connections that use Unix domain sockets rather
than TCP.

Fix tokio-rs#296.
benesch added a commit to benesch/tokio-console that referenced this issue Dec 11, 2022
@benesch
feat(console): add support for Unix domain sockets
bac69ec 
Add support for console connections that use Unix domain sockets rather
than TCP.

Fix tokio-rs#296.
benesch added a commit to benesch/tokio-console that referenced this issue Dec 16, 2022
@benesch
feat(console): add support for Unix domain sockets
661756b 
Add support for console connections that use Unix domain sockets rather
than TCP.

Fix tokio-rs#296.
benesch added a commit to benesch/tokio-console that referenced this issue Dec 28, 2022
@benesch
feat(console): add support for Unix domain sockets
19ce422 
Add support for console connections that use Unix domain sockets rather
than TCP.

Fix tokio-rs#296.
hawkw added a commit that referenced this issue Mar 28, 2023
@benesch @hawkw
feat(console): add support for Unix domain sockets (#388)
bff8b8a 
Add support for console connections that use Unix domain sockets rather
than TCP.

Closes #296.

Co-authored-by: Eliza Weisman <eliza@buoyant.io>
hawkw added a commit that referenced this issue Sep 29, 2023
@benesch @hawkw
feat(console): add support for Unix domain sockets (#388)
a944dbc 
Add support for console connections that use Unix domain sockets rather
than TCP.

Closes #296.

Co-authored-by: Eliza Weisman <eliza@buoyant.io>
hawkw added a commit that referenced this issue Sep 29, 2023
@hawkw
chore(subscriber): prepare to release console-subscriber 0.2.0
2b164b2 
# Changelog

All notable changes to this project will be documented in this file.
This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## console-subscriber-v0.2.0 - (2023-09-29)

[0b0c1af](https://github.com/tokio-rs/console/commit/0b0c1aff18c3260d3a45a78f6c0d6f4206af1cbb)...[0b0c1af](https://github.com/tokio-rs/console/commit/0b0c1aff18c3260d3a45a78f6c0d6f4206af1cbb)

### <a id = "console-subscriber-v0.2.0-breaking"></a>Breaking Changes
- **Update Tonic and Prost dependencies ([#364](#364 ([f9b8e03](https://github.com/tokio-rs/console/commit/f9b8e03bd7ee1d0edb441c94a93a350d5b06ed3b))<br />This commit updates the public dependencies `prost` and `tonic` to
semver-incompatible versions (v0.11.0 and v0.8.0, respectively). This is
a breaking change for users who are integrating the `console-api` protos
with their own `tonic` servers or clients.
- **Update `tonic` to v0.10 and increase MSRV to 1.64 ([#464](#464 ([96e62c8](https://github.com/tokio-rs/console/commit/96e62c83ef959569bb062dc8fee98fa2b2461e8d))<br />This is a breaking change for users of `console-api` and
`console-subscriber`, as it changes the public `tonic` dependency to a
semver-incompatible version. This breaks compatibility with `tonic`
0.9.x and `prost` 0.11.x.

### Added

- [**breaking**](#console-subscriber-v0.2.0-breaking) Update Tonic and Prost dependencies ([#364](#364)) ([f9b8e03](f9b8e03))
- Add support for Unix domain sockets ([#388](#388)) ([a944dbc](a944dbc), closes [#296](#296))
- Add scheduled time per task ([#406](#406)) ([f280df9](f280df9))
- Add task scheduled times histogram ([#409](#409)) ([d92a399](d92a399))
- Update `tonic` to 0.9 ([#420](#420)) ([48af1ee](48af1ee))
- Update MSRV to Rust 1.60.0 ([b18ee47](b18ee47))
- Expose server parts ([#451](#451)) ([e51ac5a](e51ac5a))
- Add cfg `console_without_tokio_unstable` ([#446](#446)) ([7ed6673](7ed6673))
- Add warning for tasks that never yield ([#439](#439)) ([d05fa9e](d05fa9e))
- [**breaking**](#console-subscriber-v0.2.0-breaking) Update `tonic` to v0.10 and increase MSRV to 1.64 ([#464](#464)) ([96e62c8](96e62c8))

### Documented

- Fix unclosed code block ([#463](#463)) ([362bdbe](362bdbe))
- Update MSRV version docs to 1.64 ([#467](#467)) ([94a5a51](94a5a51))

### Fixed

- Fix build on tokio 1.21.0 ([#374](#374)) ([c34ac2d](c34ac2d))
- Fix off-by-one indexing for `callsites` ([#391](#391)) ([43891ab](43891ab))
- Bump minimum Tokio version ([#397](#397)) ([bbb8f25](bbb8f25), fixes [#386](#386))
- Fix self wakes count ([#430](#430)) ([d308935](d308935))
- Remove clock skew warning in `start_poll` ([#434](#434)) ([4a88b28](4a88b28))
- Do not report excessive polling ([#378](#378)) ([#440](#440)) ([8b483bf](8b483bf), closes [#378](#378))
- Correct retain logic ([#447](#447)) ([36ffc51](36ffc51))

Signed-off-by: Eliza Weisman <eliza@buoyant.io>
hawkw added a commit that referenced this issue Sep 29, 2023
@hawkw
chore(console): prepare to release tokio-console 0.1.10
05484b1 
# Changelog

All notable changes to this project will be documented in this file.
This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## tokio-console-v0.1.10 - (2023-09-29)

[7d009f8](https://github.com/tokio-rs/console/commit/7d009f87120ce0c89f5f9c5311f05b6756ca770f)...[7d009f8](https://github.com/tokio-rs/console/commit/7d009f87120ce0c89f5f9c5311f05b6756ca770f)

### <a id = "tokio-console-v0.1.10-breaking"></a>Breaking Changes
- **Update Tonic and Prost dependencies ([#364](#364 ([f9b8e03](https://github.com/tokio-rs/console/commit/f9b8e03bd7ee1d0edb441c94a93a350d5b06ed3b))<br />This commit updates the public dependencies `prost` and `tonic` to
semver-incompatible versions (v0.11.0 and v0.8.0, respectively). This is
a breaking change for users who are integrating the `console-api` protos
with their own `tonic` servers or clients.
- **Update `tonic` to v0.10 and increase MSRV to 1.64 ([#464](#464 ([96e62c8](https://github.com/tokio-rs/console/commit/96e62c83ef959569bb062dc8fee98fa2b2461e8d))<br />This is a breaking change for users of `console-api` and
`console-subscriber`, as it changes the public `tonic` dependency to a
semver-incompatible version. This breaks compatibility with `tonic`
0.9.x and `prost` 0.11.x.

### Added

- [**breaking**](#tokio-console-v0.1.10-breaking) Update Tonic and Prost dependencies ([#364](#364)) ([f9b8e03](f9b8e03))
- Only suggest opening issues for panics ([#365](#365)) ([da2a89c](da2a89c))
- Init error handling before subcmds ([#365](#365)) ([ec66eda](ec66eda))
- Filter out boring frames in backtraces ([#365](#365)) ([95a5e54](95a5e54))
- Include config options in autogenerated issues ([#365](#365)) ([3244a1f](3244a1f))
- Reduce decimal digits in UI ([#402](#402)) ([c13085e](c13085e))
- Use tokio task ids in task views ([#403](#403)) ([f5b06d2](f5b06d2))
- Add support for Unix domain sockets ([#388](#388)) ([a944dbc](a944dbc), closes [#296](#296))
- Add scheduled time per task ([#406](#406)) ([f280df9](f280df9))
- Add task scheduled times histogram ([#409](#409)) ([d92a399](d92a399))
- Update `tonic` to 0.9 ([#420](#420)) ([48af1ee](48af1ee))
- Update MSRV to Rust 1.60.0 ([b18ee47](b18ee47))
- Migrate to `ratatui` and update `crossterm` ([#425](#425)) ([b209dd6](b209dd6))
- Help view modal ([#432](#432)) ([359a4e7](359a4e7))
- Add way to inspect details of task from resource view ([#449](#449)) ([132ed4e](132ed4e), closes [#448](#448))
- Add warning for tasks that never yield ([#439](#439)) ([d05fa9e](d05fa9e))
- [**breaking**](#tokio-console-v0.1.10-breaking) Update `tonic` to v0.10 and increase MSRV to 1.64 ([#464](#464)) ([96e62c8](96e62c8))

### Documented

- Update screenshots in README ([#419](#419)) ([e9bcd67](e9bcd67))
- Revert "update screenshots in README ([#419](#419))" ([993a3d9](993a3d9))
- Update screenshots in README ([#421](#421)) ([8a27f96](8a27f96))
- Add column descriptions for all tables ([#431](#431)) ([e3cf82b](e3cf82b))
- Update MSRV version docs to 1.64 ([#467](#467)) ([94a5a51](94a5a51))

### Fixed

- Fix ascii-only flipped input ([#377](#377)) ([652ac34](652ac34))
- Declare `tokio-console` bin as `default-run` ([#379](#379)) ([9ce60ec](9ce60ec))
- Make `retain_for` default to 6s if not specfied ([#383](#383)) ([0a6012b](0a6012b), fixes [#382](#382))
- Enable view-switching keystrokes on details views ([#387](#387)) ([f417d7a](f417d7a))
- Fix `ViewOptions` default lang' ([#394](#394)) ([a1cf1b8](a1cf1b8), fixes [#393](#393))
- Remove `tracing-subscriber` 0.2 from dependencies ([#404](#404)) ([768534a](768534a))
- Fix calculation of busy time during poll ([#405](#405)) ([e2c536a](e2c536a))
- Remove histogram minimum count ([#424](#424)) ([02cf8a6](02cf8a6))
- Remove trailing space from task/resource location ([#443](#443)) ([90e5918](90e5918))
- Make long locations readable ([#441](#441)) ([9428d7f](9428d7f), closes [#411](#411))
- Fix task detail view Id to display remote tokio::task::Id ([#455](#455)) ([70c3952](70c3952))

Signed-off-by: Eliza Weisman <eliza@buoyant.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(console): add support for Unix domain sockets benesch/tokio-console
3 participants
@hawkw @quanweiZhou @Milo123459