From 2c511220005b0e46712fa68335ded17ebaa49ae8 Mon Sep 17 00:00:00 2001 From: Carl Lerche Date: Sat, 17 Oct 2020 15:22:41 -0700 Subject: [PATCH] remove `new` fns from combinator structs This is not idiomatic. --- src/buf/chain.rs | 2 +- src/buf/iter.rs | 5 ++--- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/src/buf/chain.rs b/src/buf/chain.rs index cc2c944b7..894d8b75e 100644 --- a/src/buf/chain.rs +++ b/src/buf/chain.rs @@ -38,7 +38,7 @@ pub struct Chain { impl Chain { /// Creates a new `Chain` sequencing the provided values. - pub fn new(a: T, b: U) -> Chain { + pub(crate) fn new(a: T, b: U) -> Chain { Chain { a, b } } diff --git a/src/buf/iter.rs b/src/buf/iter.rs index 0f9bdc04f..16a2c5543 100644 --- a/src/buf/iter.rs +++ b/src/buf/iter.rs @@ -34,17 +34,16 @@ impl IntoIter { /// /// ``` /// use bytes::Bytes; - /// use bytes::buf::IntoIter; /// /// let buf = Bytes::from_static(b"abc"); - /// let mut iter = IntoIter::new(buf); + /// let mut iter = buf.into_iter(); /// /// assert_eq!(iter.next(), Some(b'a')); /// assert_eq!(iter.next(), Some(b'b')); /// assert_eq!(iter.next(), Some(b'c')); /// assert_eq!(iter.next(), None); /// ``` - pub fn new(inner: T) -> IntoIter { + pub(crate) fn new(inner: T) -> IntoIter { IntoIter { inner } }