Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prepare v1.0.0 release #451

Merged
merged 6 commits into from Dec 20, 2020
Merged

prepare v1.0.0 release #451

merged 6 commits into from Dec 20, 2020

Conversation

aknuds1
Copy link
Contributor

@aknuds1 aknuds1 commented Dec 19, 2020

No description provided.

@aknuds1
Update changelog for v1.0.0
48ffb0f 
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
@aknuds1
Copy link
Contributor Author

aknuds1 commented Dec 19, 2020

@Darksonn How do I compile the changelog?

@Darksonn
Copy link
Contributor

Read the list of commits backwards until the last preparation PR.

@aknuds1
Remove publish directive
04a22cc 
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
@aknuds1
Refer to 1.0 in README
d0e7bb2 
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
@aknuds1
Add changelog entries
d2d05c6 
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
@Darksonn Darksonn marked this pull request as ready for review December 19, 2020 11:59
carllerche
carllerche requested changes Dec 19, 2020
View reviewed changes
Copy link
Member

@carllerche carllerche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Thanks for doing this. We are going to hold off doing the actual release until Tokio is ready for the release as well. However, we can merge most of this 👍 Some thoughts inline.

CHANGELOG.md Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
aknuds1 and others added 2 commits December 20, 2020 01:05
@aknuds1 @carllerche
Update CHANGELOG.md
7fd3e50 
Co-authored-by: Carl Lerche <me@carllerche.com>
@aknuds1
Revert change to Cargo.toml
2aa5fc3 
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
@carllerche carllerche merged commit e398b0a into tokio-rs:master Dec 20, 2020
@dependabot dependabot bot mentioned this pull request Mar 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carllerche carllerche carllerche approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aknuds1 @Darksonn @carllerche