Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove byteorder dependency #280

Merged
merged 2 commits into from Aug 11, 2019
Merged

Conversation

DoumanAsh
Copy link
Contributor

This what it takes to remove the dependency.
It is a bit difficult to make it generic to retrieve le/be from array because std methods only allow plain sized array.
But it shouldn't be performance hit because byteorder copies slices always

Fixes #279

src/buf/buf.rs Outdated Show resolved Hide resolved
Copy link
Member

@carllerche carllerche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@carllerche carllerche merged commit 234d814 into tokio-rs:master Aug 11, 2019
@DoumanAsh DoumanAsh deleted the remove_byteorder branch August 11, 2019 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove byteorder-dependency?
3 participants