Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove i128 feature #276

Merged
merged 3 commits into from Jul 30, 2019
Merged

Remove i128 feature #276

merged 3 commits into from Jul 30, 2019

Conversation

taiki-e
Copy link
Member

@taiki-e taiki-e commented Jul 27, 2019 •
edited

byteorder v1.3 (or later) automatically detects the rustc version and enables i128 support.

Refs: BurntSushi/byteorder@168648f

carllerche
carllerche approved these changes Jul 30, 2019
View reviewed changes
Copy link
Member

@carllerche carllerche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

I think you will need to merge master to get this to pass CI now.

@carllerche
Copy link
Member

Waiting to see if the deploy docs task is fixed here.

@carllerche
Copy link
Member

Trying again: https://dev.azure.com/tokio-rs/bytes/_build/results?buildId=1703

@carllerche carllerche merged commit b5d4f87 into tokio-rs:master Jul 30, 2019
@taiki-e
Copy link
Member Author

taiki-e commented Jul 30, 2019

Thanks for the fix.

@taiki-e taiki-e deleted the byteorder branch July 30, 2019 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carllerche carllerche carllerche approved these changes

@seanmonstar seanmonstar Awaiting requested review from seanmonstar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@taiki-e @carllerche