Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace iovec with std::io::IoSlice #263

Merged
merged 1 commit into from Jun 11, 2019
Merged

Replace iovec with std::io::IoSlice #263

merged 1 commit into from Jun 11, 2019

Conversation

seanmonstar
Copy link
Member

Closes #224

@archseer
Copy link

archseer commented Jun 8, 2019

Should these be renamed to match the iovec methods in the standard library? _vec -> _vectored
stdlib also returns Result<usize> instead of usize, but I'm not sure that's applicable here.

@seanmonstar
Copy link
Member Author

_vec -> _vectored

I think this makes sense, it's clearer they are meant for "vectored IO", not for Vec.

Thoughts @carllerche?

@carllerche
Copy link
Member

sure.

@seanmonstar seanmonstar force-pushed the ioslice branch 2 times, most recently from e47fd57 to 40b9d4c Compare June 10, 2019 17:47
- Renames `bytes_vec` to `bytes_vectored` and `bytes_vec_mut` to
  `bytes_vectored_mut`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace iovec with std::io::IoSlice
3 participants