Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider disallowing root nesting #2651

Open
jplatte opened this issue Mar 14, 2024 · 1 comment
Open

Consider disallowing root nesting #2651

jplatte opened this issue Mar 14, 2024 · 1 comment
Labels
A-axum breaking change A PR that makes a breaking change. T-release Topic: releases
Milestone

Comments

@jplatte
Copy link
Member

jplatte commented Mar 14, 2024

Before the 0.8.0 release, I would like to come back to nest("/", router) and nest_service("/", svc). I believe I suggested disallowing them (in favor of merge and fallback_service) before, but if so there must have been some pushback by David since we still allow both.

Any pointers or thoughts appreciated.

@jplatte jplatte added A-axum breaking change A PR that makes a breaking change. T-release Topic: releases labels Mar 14, 2024
@jplatte jplatte added this to the 0.8 milestone Mar 14, 2024
@jplatte
Copy link
Member Author

jplatte commented Mar 17, 2024

The only thing I found is this: #2012
… which suggests I'm wrong about previous push-back and we should just disallow root nesting :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-axum breaking change A PR that makes a breaking change. T-release Topic: releases
Projects
None yet
Development

No branches or pull requests

1 participant