Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update matchit to 0.8 #2641

Open
1 task done
mladedav opened this issue Mar 10, 2024 · 2 comments · May be fixed by #2645
Open
1 task done

Update matchit to 0.8 #2641

mladedav opened this issue Mar 10, 2024 · 2 comments · May be fixed by #2645
Assignees
@mladedav
Labels
A-axum breaking change A PR that makes a breaking change. E-medium Call for participation: Experience needed to fix: Medium / intermediate
Milestone
0.8

Comments

@mladedav
Copy link
Contributor

  • I have looked for existing issues (including closed) about this

Proposal

matchit version 0.8 was just released.

It includes changes to the syntax so now instead of /path/:arg/*wildcard it uses /path/{arg}/{*wildcard}. There are some other changes such as that now /path and /path/ are distinct.

All tests, examples, and documentation must be updated, otherwise the change is trivial.

This is a breaking change.
@jplatte
Copy link
Member

jplatte commented Mar 10, 2024

Do you want to work on this? It would be very appreciated :)

@mladedav
Copy link
Contributor Author

Yeah, sure.

Can you please add the breaking change (and possibly other) labels and add this to the 0.8 milestone?

@jplatte jplatte added E-medium Call for participation: Experience needed to fix: Medium / intermediate breaking change A PR that makes a breaking change. A-axum labels Mar 11, 2024
@jplatte jplatte added this to the 0.8 milestone Mar 11, 2024
@mladedav mladedav linked a pull request Mar 12, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mladedav mladedav

Labels
A-axum breaking change A PR that makes a breaking change. E-medium Call for participation: Experience needed to fix: Medium / intermediate
Projects
None yet
Milestone
0.8
Development

Successfully merging a pull request may close this issue.

chore: update matchit to 0.8 mladedav/axum
2 participants
@jplatte @mladedav