Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move axum-extra's Html response into axum #2632

Open
jplatte opened this issue Mar 5, 2024 · 0 comments · May be fixed by #2633
Open

Move axum-extra's Html response into axum #2632

jplatte opened this issue Mar 5, 2024 · 0 comments · May be fixed by #2633
Labels
A-axum breaking change A PR that makes a breaking change. E-easy Call for participation: Experience needed to fix: Easy / not much
Milestone
0.8

Comments

@jplatte
Copy link
Member

jplatte commented Mar 5, 2024

In #1921, David added an Html response type that adds ; charset=utf-8 to the content-type (this might need further discussion) and has a different bound on the inner type than axum's Html response type. It was meant to be replace the latter for axum 0.7.0 originally, but was forgotten for that release.

We should move it with the next breaking-change release.
@jplatte jplatte added E-easy Call for participation: Experience needed to fix: Easy / not much breaking change A PR that makes a breaking change. A-axum labels Mar 5, 2024
@jplatte jplatte added this to the 0.8 milestone Mar 5, 2024
@creativcoder creativcoder linked a pull request Mar 5, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-axum breaking change A PR that makes a breaking change. E-easy Call for participation: Experience needed to fix: Easy / not much
Projects
None yet
Milestone
0.8
Development

Successfully merging a pull request may close this issue.

Move Html from axum-extra to axum creativcoder/axum
1 participant
@jplatte