Fix missing Allow when middleware are applied to MethodRouter
#1773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #1770 To be totally honest I don't understand why this fixes the issue.
jplatte
approved these changes
Feb 20, 2023
| @@ -155,9 +155,6 @@ where | |||
|
|
|||
| #[inline] | |||
| fn poll(self: Pin<&mut Self>, cx: &mut Context<'_>) -> Poll<Self::Output> { | |||
| #[derive(Clone, Copy)] | |||
| struct AlreadyPassedThroughRouteFuture; | |||
There was a problem hiding this comment.
Maybe dig up the PR that introduced this via git blame?
There was a problem hiding this comment.
I did that here
tbh I'm not totally sure why everything still worked after removing this. Doesn't seem related to this change because it also works on
mainif you remove this. So must be something else that changed 🤷#755 did add a regression test and I also tried the repro from #747. Both worked correctly.
and tested specifically the repro from the issue and everything worked fine. So something else must have changed that made AlreadyPassedThroughRouteFuture unnecessary.
|
Oh yeah theres a failing tests. That interesting 😅 |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1770
To be totally honest I don't understand why this fixes the issue. I also noticed some weirdness in this piece of the code in https://github.com/tokio-rs/axum/pull/1711/files#r1082406463. Removing it doesn't seem to break anything else, and the bug it was originally added to fix doesn't occur anymore.
The reason its pretty hard to follow I think is that we wrap things in
Routequite a bit, which also wraps the response future inRouteFuture. So there are several layers ofRouteFuturebeing called and previously mutating the response.