Fix warnings for cloning references in generated code #1676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In tokio-rs#1674, it was pointed out that `axum-macros` causes some `clippy` warnings (and some `rustc` lints to fail) as the `FromRef` macro generates code which clones reference types unnecessarily. This seems to be when generating the body of the trait implementation, but since we have the type information from `syn` at that point it's relatively simple to resolve these. This change: * Avoids using `.clone` if we are generating the implementation for a reference type field * Adds a simple UI test to ensure this compiles with the `rustc` lint set to deny Fixes tokio-rs#1674.
|
Wanna add a note to changelog as well? |
davidpdrsn
changed the title
|
@davidpdrsn I don't mind, happy to add one if it's worth it 😅 not the most exciting of changes though, I presume |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In #1674, it was pointed out that
axum-macroscauses someclippywarnings (and somerustclints to fail) as theFromRefmacro generates code which clones reference types unnecessarily.Solution
This seems to be when generating the body of the trait implementation, but since we have the type information from
synat that point it's relatively simple to resolve these.This change:
.cloneif we are generating the implementation for a reference type fieldrustclint set to denyFixes #1674.