Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to base64 0.20 #1641

Merged
merged 2 commits into from Jan 8, 2023
Merged

Update to base64 0.20 #1641

merged 2 commits into from Jan 8, 2023

Conversation

Austaras
Copy link
Contributor

@Austaras Austaras commented Dec 15, 2022 •
edited

Motivation

Just want one less entry in my Cargo.lock

Solution

Status of dependency

  • cookie-rs, updated and released
  • headers, pending
  • tower-http, waiting for release
  • reqwest, waiting for release
  • tungstenite, waiting for release

davidpdrsn
davidpdrsn approved these changes Dec 15, 2022
View reviewed changes
Copy link
Member

@davidpdrsn davidpdrsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@davidpdrsn davidpdrsn enabled auto-merge (squash) December 15, 2022 11:30
@davidpdrsn
Copy link
Member

It seems base64 also needs to be updated in some of axum's dependencies.

I've file three PRs:

Still missing reqwest and tungstenite. I might do those later but you're also welcome to do it!

@davidpdrsn davidpdrsn added the S-blocked Status: marked as blocked ❌ on something else such as a PR or other implementation work. label Dec 16, 2022
@davidpdrsn
Copy link
Member

We can probably just merge this while we wait for axum's dependencies to update.

@davidpdrsn davidpdrsn merged commit 6638b27 into tokio-rs:main Jan 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidpdrsn davidpdrsn davidpdrsn approved these changes

Assignees
No one assigned
Labels
S-blocked Status: marked as blocked ❌ on something else such as a PR or other implementation work.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Austaras @davidpdrsn