Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing import of http in docs example #1613

Merged
merged 1 commit into from Dec 2, 2022

Conversation

cemremengu
Copy link
Contributor

@cemremengu cemremengu commented Dec 2, 2022

Wouldn't compile without importing self for http

@davidpdrsn
Copy link
Member

Wait, how why? We run doc tests on CI so why did this pass before?

@davidpdrsn
Copy link
Member

Ah of course its because axum depends in http itself, nvm :P

@davidpdrsn davidpdrsn changed the title docs: add self to from_fn Add missing import of http in docs example Dec 2, 2022
@davidpdrsn davidpdrsn enabled auto-merge (squash) December 2, 2022 14:36
@davidpdrsn davidpdrsn merged commit 5826ca2 into tokio-rs:main Dec 2, 2022
@cemremengu cemremengu deleted the patch-1 branch December 2, 2022 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants