Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New release candidates #1541

Merged
merged 1 commit into from Nov 18, 2022
Merged

New release candidates #1541

merged 1 commit into from Nov 18, 2022

Conversation

davidpdrsn
Copy link
Member

With a little bit of luck this might be the last round of rcs.

@davidpdrsn davidpdrsn added the T-release Topic: releases label Nov 18, 2022
@jplatte
Copy link
Member

jplatte commented Nov 18, 2022

Yes, this has strong final-rc vibes 😄

@davidpdrsn davidpdrsn merged commit 878ae73 into main Nov 18, 2022
@davidpdrsn davidpdrsn deleted the new-rcs branch November 18, 2022 16:29
@Adhalianna
Copy link

Adhalianna commented Nov 18, 2022

Could it be that axum-extra is still missing compatibility with the new release candidate? I have just found out about the new rc accidentally through cargo-update and I started getting this compilation error:

error[E0061]: this function takes 2 arguments but 1 argument was supplied
   --> /../github.com-1ecc6299db9ec823/axum-extra-0.4.0-rc.2/src/routing/resource.rs:64:21
    |
64  |             router: Router::with_state(state),
    |                     ^^^^^^^^^^^^^^^^^^ ----- an argument of type `Router<_, _>` is missing
    |
note: associated function defined here
   --> /../github.com-1ecc6299db9ec823/axum-0.6.0-rc.5/src/routing/mod.rs:399:12
    |
399 |     pub fn with_state(self, state: S) -> RouterService<B> {
    |            ^^^^^^^^^^
help: provide the argument
    |
64  |             router: Router::with_state(/* value */, state),
    |                                       ~~~~~~~~~~~~~~~~~~~~

error[E0308]: mismatched types
  --> /../github.com-1ecc6299db9ec823/axum-extra-0.4.0-rc.2/src/routing/resource.rs:64:21
   |
64 |             router: Router::with_state(state),
   |                     ^^^^^^^^^^^^^^^^^^^^^^^^^ expected struct `Router`, found struct `RouterService`
   |
   = note: expected struct `Router<S, B>`
              found struct `RouterService<_>`

EDIT: It might be that my worry is premature since after a round of cargo-clean, cargo-update my project stopped compiling on errors in another dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-release Topic: releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants