Fixed docs for chained method routing #1355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jplatte
reviewed
Sep 8, 2022
axum/src/routing/method_routing.rs
Outdated
Comment on lines
181
to
182
| /// // Requests to `GET /` will go to `other_service` and `POST /` will go to | ||
| /// // `service`. |
There was a problem hiding this comment.
Maybe swap GET and POST instead of service and other_service (i.e. update the ordering within the sentence)? I think that would make this comment easier to follow.
axum/src/routing/method_routing.rs
Outdated
Comment on lines
245
to
246
| /// // Requests to `GET /` will go to `other_handler` and `POST /` will go to | ||
| /// // `handler`. |
fmeringdal
force-pushed
the
fix/chained-method-router-docs
branch
from
50c59c7
to
f8c3a49
Compare
jplatte
approved these changes
Sep 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, thanks for the amazing work on this crate!
I was browsing the internals of the routing and found some incorrect public documentation for the chained method routing.