More robust asset paths in examples #1090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jplatte
reviewed
Jun 15, 2022
| @@ -30,8 +37,8 @@ async fn main() { | |||
| .init(); | |||
|
|
|||
| let rustls_config = rustls_server_config( | |||
| "examples/tls-rustls/self_signed_certs/key.pem", | |||
| "examples/tls-rustls/self_signed_certs/cert.pem", | |||
| PathBuf::from(env!("CARGO_MANIFEST_DIR")).join("self_signed_certs/key.pem"), | |||
There was a problem hiding this comment.
Maybe use platform-native path separators while you're at it?
Suggested change
| PathBuf::from(env!("CARGO_MANIFEST_DIR")).join("self_signed_certs/key.pem"), | |
| PathBuf::from(env!("CARGO_MANIFEST_DIR")).join("self_signed_certs").join("key.pem"), |
There was a problem hiding this comment.
This isn't resolved, there's at three more of these /es in string literals in the PR 😄
There was a problem hiding this comment.
Oh whoops sorry. I'll fix those!
Co-authored-by: Jonas Platte <jplatte+git@posteo.de>
jplatte
approved these changes
Jun 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1089 for the other examples that read assets.