Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix missing assets running websockets example #1089

Merged
merged 4 commits into from Jun 15, 2022
Merged

fix missing assets running websockets example #1089

merged 4 commits into from Jun 15, 2022

Conversation

yshing
Copy link
Contributor

@yshing yshing commented Jun 12, 2022

Motivation

Checking out the websockets example recently. When running cargo run under examples/websockets, the example app isn't serving any assets.

image

Solution

Make the assets folder relative to CARGO_MANIFEST_DIR.

@jplatte
Copy link
Member

jplatte commented Jun 14, 2022

I think this makes sense in the context of the example, wdyt @davidpdrsn?

davidpdrsn
davidpdrsn reviewed Jun 14, 2022
View reviewed changes
Copy link
Member

@davidpdrsn davidpdrsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I think it makes sense! I've been bitten by this myself while testing stuff :P

examples/websockets/src/main.rs Outdated Show resolved Hide resolved
yshing and others added 3 commits June 14, 2022 19:47
@davidpdrsn davidpdrsn merged commit cbb2e8a into tokio-rs:main Jun 15, 2022
@davidpdrsn davidpdrsn mentioned this pull request Jun 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidpdrsn davidpdrsn davidpdrsn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yshing @jplatte @davidpdrsn