We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When using pyrsistent.typing and PVector, mypy (version 0.931) gives the following error:
pyrsistent.typing
PVector
Missing positional argument "stop" in call to "delete" of "PVector"
Here is a minimal example to reproduce the issue:
from pyrsistent import pvector from pyrsistent.typing import PVector p1: PVector = pvector([1, 2, 3]) p2: PVector = p1.delete(0) # Missing positional argument "stop" in call to "delete" of "PVector"
Changing line 71 in typing.pyi to have a default optional argument of None seems to fix the error:
typing.pyi
None
71: - def delete(self, index: int, stop: Optional[int]) -> PVector[T]: ... 71: + def delete(self, index: int, stop: Optional[int] = None) -> PVector[T]: ...
The text was updated successfully, but these errors were encountered:
OK! Do you want to put up a tiny PR for it or should I go ahead and make the change Seems reasonable to me. Sorry for the delay in responding...
Sorry, something went wrong.
Update typing.pyi
5501693
Fixes tobgu#244
Done!
Successfully merging a pull request may close this issue.
When using
pyrsistent.typing
andPVector
, mypy (version 0.931) gives the following error:Missing positional argument "stop" in call to "delete" of "PVector"
Here is a minimal example to reproduce the issue:
Changing line 71 in
typing.pyi
to have a default optional argument ofNone
seems to fix the error:The text was updated successfully, but these errors were encountered: