Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyrsistent needs wheels #223

Closed
JanneKiiskila opened this issue Mar 23, 2021 · 5 comments
Closed

pyrsistent needs wheels #223

JanneKiiskila opened this issue Mar 23, 2021 · 5 comments

Comments

@JanneKiiskila
Copy link

Long story short - as per PelionIoT/manifest-tool#27 it turns out pyrsistent needs some wheels.
It does not currently specify them in it's own requirements.txt, so that should be added there.

@JanneKiiskila
Copy link
Author

This is from a colleague of mine; @moshe Shahar

After investigating a bit more, this behavior has changed from pip v20.1.1, and from that version, you will see:
Using legacy 'setup.py install' for pyrsistent, since package 'wheel' is not installed.

The correct fix is to add setup_requires = wheel to setup.py in the packages that don’t provide pre-built wheels such as pyrsistent.

@jaraco
Copy link
Contributor

jaraco commented May 18, 2021

I believe this is a dupe of #196.

Also, please don't use setup_requires. Instead, use pyproject.toml and build-requires (PEP 518).

@johnthagen
Copy link
Contributor

Should be fixed in #227

@tobgu
Copy link
Owner

tobgu commented Jun 19, 2021

Thanks @johnthagen for contributing to this happening. I've released wheels for 0.17.4rc1 now. It would be great with some testing and feedback before I cut a proper release if anyone has the chance to do so.

@tobgu
Copy link
Owner

tobgu commented Jul 3, 2021

Release 0.18.0 is has wheels built.

@tobgu tobgu closed this as completed Jul 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants