Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh page content when changing the file associated with an application page ID #73

Open
gbl08ma opened this issue Jun 5, 2023 · 0 comments
Labels
backend enhancement New feature or request frontend JungleTV AF Something related to the JungleTV Application Framework
Milestone

Comments

@gbl08ma
Copy link
Member

gbl08ma commented Jun 5, 2023

When republishing a previously published page ID (by passing the previous ID to publishFile but using a different file name) the page needs to be reloaded on connected clients. This is to be more consistent with what happens when a page is unpublished (where the page turns into a 404/disappears in chat). The mechanism for conveying the change to the frontend can be similar (through an application event message used by the RPC return/event channel).

However, to consider: not selected sidebar tabs will retain their previous title. It may be wise to also trigger a sidebar tab register-unregister cycle to cause a configuration change to be broadcasted (similar to what is done when setSidebarTab is called with a different pageID). Keeping the same beforeTabID may be a challenge.

@gbl08ma gbl08ma added enhancement New feature or request frontend backend JungleTV AF Something related to the JungleTV Application Framework labels Jun 5, 2023
@gbl08ma gbl08ma added this to the vCurrent milestone Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend enhancement New feature or request frontend JungleTV AF Something related to the JungleTV Application Framework
Projects
None yet
Development

No branches or pull requests

1 participant