Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bullet proofing for capture_pane #456

Open
tony opened this issue Nov 5, 2022 · 0 comments
Open

Bullet proofing for capture_pane #456

tony opened this issue Nov 5, 2022 · 0 comments

Comments

@tony
Copy link
Member

tony commented Nov 5, 2022 •
edited

This is an existential issue for libtmux / tmuxp

I think it's going to take some thinking.

Ideas:

  • sending a sentinel command made to figure out what the PS1 and shell is.
  • building in support for polling capture_pane() (similar to playwright / selenium)
  • finding "flake-free" / "rock-solid" loadouts for capturing pane text. Reliable enough to be used downstream in tests and across platforms

What we need:

  • What are the user's needs when running capture_pane()?
    • Is it just to boot up a daemon or process in the background?
    • Do they need consistency and determinism in shell commands across systems, or do they want to use their own environment's shell / configuration and deal with the output inconsistency themselves?
  • If they're willing to make any compromises: limiting their shell, using a barebones shell configuration in panes, or making it clear bringing your own shell / configuration may be hard to provide reliable results for

See also: #454
@tony tony mentioned this issue Nov 5, 2022
Merged
tony added a commit that referenced this issue Nov 5, 2022
@tony
test(test_capture_pane): Remove bashisms (#455)
74d600b 
In an effort to reduce reliance on specific shells so tests
and development works across as many machines as possible,
avoid explicitly mentioning shells. re: #454

There's an issue: What about fish? It departs greatly from
other shells.  Is there a way we can have tests and a capture_pane
that works everywhere? #456
@tony tony mentioned this issue Nov 5, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
libtmux
Status: No status
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tony