Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚠️ Imports moving in v0.13: libtmux.Server -> libtmux.server.Server, etc #386

Open
tony opened this issue Jul 31, 2022 · 0 comments
Open

Comments

@tony
Copy link
Member

tony commented Jul 31, 2022

This can cause tricky circular imports / cyclic dependency issues that get in the way of mypy, MonkeyType, and our API documentation.

Looking for feedback on this.

Is it a deal-breaker for you?

Server

Before

from libtmux import Server

After

from libtmux.server import Server

Session

Before

from libtmux import Session

After

from libtmux.server import Server

Window

Before

from libtmux import Window

After

from libtmux.window import Window

Pane

Before

from libtmux import Pane

After

from libtmux.pane import Pane
@tony tony pinned this issue Jul 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant