Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add showBrowser config option to print browser for each spec #80

Merged
merged 2 commits into from Apr 11, 2022

Conversation

squarebracket
Copy link
Contributor

Simple PR to append the browser name to the spec name if desired.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 87.288% when pulling 98718cf on squarebracket:master into 9339a2b on mlex:master.

@joeyparrish
Copy link

@tmcgee123, can you please take a look at this? I was about to file an issue asking for this same feature. When running tests on a large Selenium grid, it is critical to know which browser reported which failure.

@tmcgee123
Copy link
Owner

Sorry for the delay. Thank you for your contribution!

@tmcgee123 tmcgee123 merged commit b7a0051 into tmcgee123:master Apr 11, 2022
@tmcgee123
Copy link
Owner

@tmcgee123, can you please take a look at this? I was about to file an issue asking for this same feature. When running tests on a large Selenium grid, it is critical to know which browser reported which failure.

Sorry for the delay. The changes should now be available when you update to the latest package via npm.

Cheers!

@joeyparrish
Copy link

That's wonderful, thank you so much! I was about to update my project to point to a fork while I waited for that.

From my limited perspective, it's no delay at all. I only found the PR in a search earlier this morning. 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants