Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs updates #290

Merged
merged 12 commits into from Jul 9, 2022
Merged

Docs updates #290

merged 12 commits into from Jul 9, 2022

Conversation

tomato42
Copy link
Member

@tomato42 tomato42 commented Apr 2, 2022

Project description, badge, more updates to docs

Work towards #95
fixes #278

@tomato42 tomato42 added the maintenance issues related to making the project usable or testable label Apr 2, 2022
@tomato42 tomato42 added this to the v0.18.0 milestone Apr 2, 2022
@tomato42 tomato42 self-assigned this Apr 2, 2022
@tomato42 tomato42 mentioned this pull request Apr 20, 2022
@tomato42 tomato42 requested a review from ueno June 28, 2022 10:13
Copy link

@ueno ueno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well written, I could only find minor nits.

which numerical OID maps to which curve parameters. Thus the prospect of
using the explicit encoding, where all the needed parameters are provided
is tempting, the downside is that curve parameters may specify a *weak*
curve, which is easy to attack and break (that is deduce the private key
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"that is to deduce" maybe?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

Elliptic Curve Digital Signature Algorithm

EdDSA
Edward curve based Digital Signature Algorithm, the alternative
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edward → Edwards

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes


EdDSA
Edward curve based Digital Signature Algorithm, the alternative
digitial signature algorithm that's used for Curve25519 or Curve448
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

digitial → digital

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

encoding of NIST256p public key will be 65 bytes long.

PEM
The acronym stands for Privacy Enhanced Email, but currently it is used
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Privacy Enhanced Mail?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, should be "Mail"


bytes-like object
All the types that implement the buffer protocol. That includes
``str`` (only on python2), ``bytes``, ``bytesarray``, ``array.array``
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bytesarraybytearray?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right

@tomato42
Copy link
Member Author

tomato42 commented Jul 8, 2022

@ueno Thanks, I've fixed the issues.

@tomato42 tomato42 merged commit 3a8bc4e into tlsfuzzer:master Jul 9, 2022
@tomato42 tomato42 deleted the docs-updates branch July 9, 2022 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance issues related to making the project usable or testable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explain how to use library for simple point arithmetic
2 participants