imports multi-line grammar

[chawlanitin]

@tliron I am trying to parse a package that has an import definition in line with the example specified in Tosca

imports:
- nodes:
     file: nodes.yml

but on parsing the package using puccini, I am getting the following error:

@18,3 imports[0].nodes: unsupported field
@18,3 imports[0].url: missing required field

Could you please confirm is this a bug in Puccini or the grammar used in the package is not correct?

[tliron]

I'm quite sure that the correct syntax is this:

imports:
- path1/path2/some_defs.yaml
- file: path1/path2/file2.yaml
  repository: my_service_catalog
  ...

[tliron]

By the way, you did discover a bug I will fix -- the "missing required field" report uses the wrong field name. In this case it's "file" not "url".

[jpc4242]

@tliron. Yes, what you show is the correct syntax according to TOSCA "definition", but the TOSCA document has an "autoincompatible" example. Is the same as substitution mapping being an array or a map that forced puccini to have a dedicated quirk.
I guess we should have a new quirk here, ONAP CSARS are using the "wrong" format because they based their code on the example provided in TOSCA document.
BTW: The "wrong" example appears in tosca 1.1 and tosca 1.2. It was corrected in tosca 1.3

[tliron]

Is ONAP still locked in TOSCA 1.2?

[jpc4242]

It will probably depend on which ONAP version. I am experiencing it right now with a big telco that has a project involving ONAP "ElAlto" and the generated files use TOSCA 1.1
EDIT: I performed a search on onap cloned repos. Mostly 1.1 although some files already have 1.2 or 1.3 (and no TOSCA 2.x)

[tliron]

OK, thanks. I will convert this into an issue and implement a quirk.

[tliron]

This has been implemented in #79 as "--quirk imports.sequencedlist". I hope you can verify that it works as expected!