Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support fixed seed #131

Merged
merged 4 commits into from Oct 25, 2022
Merged

Support fixed seed #131

merged 4 commits into from Oct 25, 2022

Conversation

emilk
Copy link
Contributor

@emilk emilk commented Oct 14, 2022

Closes #126

This allows us to compile without either runtime-rng nor compile-time-rng (--no-default-features --features std).

Compiling without these flags will make ahash non-DOS-resistant.

This is meant for libraries (like egui) that

  • Don't need DOS-resistance
  • Don't want the added dependencies and compilation times of compile-time-rng
  • Don't want to force either runtime-rng or compile-time-rng onto the library users
  • Don't want to give users confusing error messages about missing getrandom when compiling for wasm32

@emilk emilk marked this pull request as ready for review October 14, 2022 07:58
@tkaitchuck tkaitchuck self-requested a review October 25, 2022 06:11
@tkaitchuck tkaitchuck merged commit 8174160 into tkaitchuck:master Oct 25, 2022
@emilk
Copy link
Contributor Author

emilk commented Oct 25, 2022

❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simple, Non-DOS-resistent seed
2 participants