Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compiler error on wasm with deault features. #129

Merged
merged 2 commits into from Oct 23, 2022
Merged

Fix compiler error on wasm with deault features. #129

merged 2 commits into from Oct 23, 2022

Conversation

ar37-rs
Copy link
Contributor

@ar37-rs ar37-rs commented Sep 23, 2022

@lukechu10 lukechu10 mentioned this pull request Oct 17, 2022
Merged
@tkaitchuck tkaitchuck self-requested a review October 23, 2022 20:31
@tkaitchuck tkaitchuck merged commit b526344 into tkaitchuck:master Oct 23, 2022
@vavrusa
Copy link

vavrusa commented Nov 2, 2022

Hi! wasm32-unknown-unknown isn't always running inside a browser, and 0.8.1 silently breaks for all other runtimes that do not provide the JS interfaces. Would you consider putting this behind a feature flag (js) just like getrandom does it?

@Frazzer951 Frazzer951 mentioned this pull request Nov 2, 2022
Closed
@tkaitchuck
Copy link
Owner

@ar37-rs Based on this, and:
#143
#141
#140
And the recomended practices here:
https://docs.rs/getrandom/latest/getrandom/#webassembly-support

I am reverting these changes to the toml file.

tkaitchuck added a commit that referenced this pull request Nov 10, 2022
@tkaitchuck
Reverting #129
a373be2 
Signed-off-by: Tom Kaitchuck <tom.kaitchuck@emc.com>
@tkaitchuck tkaitchuck mentioned this pull request Nov 10, 2022
Merged
tkaitchuck added a commit that referenced this pull request Nov 10, 2022
@tkaitchuck
Reverting #129 (#145)
4019a16 
Signed-off-by: Tom Kaitchuck <tom.kaitchuck@emc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkaitchuck tkaitchuck tkaitchuck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ar37-rs @vavrusa @tkaitchuck