Support unicode-display_width v2.0.0 #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nateberkopec
reviewed
Feb 3, 2021
| @@ -1,4 +1,4 @@ | |||
| require 'unicode/display_width/no_string_ext' | |||
| require 'unicode/display_width' | |||
There was a problem hiding this comment.
This file does not exist in v1.1.1.
There was a problem hiding this comment.
I'm not sure I follow, could you elaborate? I see https://github.com/janlelis/unicode-display_width/blob/v1.1.1/lib/unicode/display_width.rb
Also, if i pin the dependency to v1.1.1, then rake spec runs without issue.
There was a problem hiding this comment.
LOL, ignore me, no idea what I was looking at
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #104 (comment)
Adds support for
unicode-display_widthv2.0.0, and makes it the reference version inGemfile.lock. Reverts therequireincantations to remove warnings when using v2.cc @nateberkopec