Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use unicode-display_width without String ext #104

Merged
merged 1 commit into from
Oct 28, 2020
Merged

Use unicode-display_width without String ext #104

merged 1 commit into from
Oct 28, 2020

Conversation

dduugg
Copy link
Contributor

@dduugg dduugg commented Mar 8, 2019

Requires unicode-display_width without the String extensions . (A grep shows them to be unused by this library).

This option was introduced in the 1.0.0 release, so is fully compatible with the current >= 1.1.1 requirement.

This resolves issues where code can be unintentionally coupled to terminal-table by making use of these extensions, as well potentially conflicting with other libraries that may wish to extend String differently using the same method names.

@nateberkopec nateberkopec merged commit c5647ab into tj:master Oct 28, 2020
@dduugg
Copy link
Contributor Author

dduugg commented Oct 29, 2020

Thanks for the merge @nateberkopec !

Note that once v2.0 of unicode-display_width is released, this will no longer be necessary: https://github.com/janlelis/unicode-display_width/blob/bbfce64/lib/unicode/display_width/no_string_ext.rb

@dduugg dduugg deleted the no-string-ext-unicode branch October 29, 2020 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants