Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add copyInheritedSettings to README #1798

Merged

Conversation

shadowspawn
Copy link
Collaborator

Pull Request

Problem

I deliberately didn't add .copyInheritedSettings() to README in #1557 as quite technical.

But it has come up now: #1778

Solution

Only come up once, but I do prefer to mention everything offical in the README (and in a test!).

Copy link
Collaborator

@abetomo abetomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shadowspawn
Copy link
Collaborator Author

Thanks @abetomo , quick turn-around on some small changes when we are both on GitHub! 🚀

@shadowspawn shadowspawn added the pending release Merged into a branch for a future release, but not released yet label Sep 8, 2022
@shadowspawn shadowspawn merged commit 471ec40 into tj:develop Sep 8, 2022
@shadowspawn shadowspawn deleted the feature/copy-inherited-settings-doc branch September 8, 2022 09:19
@shadowspawn shadowspawn removed the pending release Merged into a branch for a future release, but not released yet label Oct 2, 2022
@shadowspawn
Copy link
Collaborator Author

Added mention to README in Commander v9.4.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants