Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade package-lock.json to lockfile@2 #1659

Merged
merged 5 commits into from Dec 21, 2021

Conversation

shadowspawn
Copy link
Collaborator

Pull Request

Problem

npm 6 and 8 use different formats for package-lock.json . Problems switching. Which shall we use?

Related: #1658

Solution

Go for the version that works nicely with Node.js v16 so convenient for developers (maintainers!) working on new versions.

Not upgrading TypeScript yet, as generates warnings from eslint.
Not upgrading eslint or any of the eslint related dependencies yet, waiting for eslint 8 compatible versions.

ChangeLog

  • changed: Update package-lock.json to lockfile@2 format.
  • changed: update dependencies

@shadowspawn
Copy link
Collaborator Author

I will do a prerelease of Commander v9 soon, but no hurry on this PR. It does not need to be in it.

Copy link
Collaborator

@abetomo abetomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2️⃣

@shadowspawn shadowspawn merged commit 08e65d3 into tj:release/9.x Dec 21, 2021
@shadowspawn shadowspawn deleted the feature/lockfile2 branch December 21, 2021 19:17
@shadowspawn shadowspawn added the pending release Merged into a branch for a future release, but not released yet label Dec 21, 2021
@shadowspawn shadowspawn added this to the Commander v9.0.0 milestone Dec 21, 2021
@shadowspawn shadowspawn removed the pending release Merged into a branch for a future release, but not released yet label Jan 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants