Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test coverage #1433

Merged
merged 6 commits into from Jan 11, 2021
Merged

Test coverage #1433

merged 6 commits into from Jan 11, 2021

Conversation

shadowspawn
Copy link
Collaborator

Pull Request

Add edge case tests to increase test coverage to everything except process.mainModule and _executeSubCommand.

Related: process.mainModule is deprecated!

@shadowspawn
Copy link
Collaborator Author

shadowspawn commented Jan 10, 2021

If we remove these two areas from the coverage:

  • process.mainModule: deprecated, will add tests when rework
  • _executeSubCommand: doing some tests using spawn which not included in coverage
----------|---------|----------|---------|---------|-------------------
File      | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s 
----------|---------|----------|---------|---------|-------------------
All files |     100 |     99.8 |     100 |     100 |                   
 index.js |     100 |     99.8 |     100 |     100 | 851               
----------|---------|----------|---------|---------|-------------------

I was thinking of removing these areas from the coverage, but reverted that commit. Will investigate what the executable tests do cover and whether can do them in a way which is counted. And try improving the coverage "honestly". 😊

Copy link
Collaborator

@abetomo abetomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding tests is great.

@shadowspawn shadowspawn added the pending release Merged into a branch for a future release, but not released yet label Jan 11, 2021
@shadowspawn shadowspawn added this to the v7.0.0 milestone Jan 11, 2021
@shadowspawn shadowspawn merged commit 891e23d into tj:develop Jan 11, 2021
@shadowspawn shadowspawn deleted the feature/test-coverage branch January 11, 2021 02:26
@shadowspawn shadowspawn removed the pending release Merged into a branch for a future release, but not released yet label Jan 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants