Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase test coverage, including incrementNodeInspectorPort #1428

Merged

Conversation

shadowspawn
Copy link
Collaborator

@shadowspawn shadowspawn commented Jan 2, 2021

Pull Request

Problem

Test coverage is less than 100%, partly due to hard to test areas of code.

Started at 92.25% for % Stmts.

Solution

Increase test coverage by adding more of the special cases, and coverage of incrementNodeInspectorPort.

Up to 97.59% for % Stmts.

@shadowspawn shadowspawn marked this pull request as ready for review January 2, 2021 19:50
@shadowspawn shadowspawn changed the title WIP: Increase test coverage Increase test coverage, including incrementNodeInspectorPort Jan 2, 2021
Copy link
Collaborator

@abetomo abetomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work

@shadowspawn shadowspawn added the pending release Merged into a branch for a future release, but not released yet label Jan 3, 2021
@shadowspawn shadowspawn added this to the v7.0.0 milestone Jan 3, 2021
@shadowspawn shadowspawn merged commit d8faba2 into tj:release/7.x Jan 3, 2021
@shadowspawn shadowspawn deleted the feature/increase-test-coverage branch January 3, 2021 19:42
@shadowspawn shadowspawn removed the pending release Merged into a branch for a future release, but not released yet label Jan 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants