Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for some getters #1369

Merged
merged 1 commit into from Oct 4, 2020
Merged

Add tests for some getters #1369

merged 1 commit into from Oct 4, 2020

Conversation

shadowspawn
Copy link
Collaborator

Pull Request

Problem

We have a setter foo(value) getter foo() pattern for some properties, but not appearing in tests.

Solution

Extend tests.

abetomo
abetomo approved these changes Oct 4, 2020
View reviewed changes
Copy link
Collaborator

@abetomo abetomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@shadowspawn shadowspawn added the pending release Merged into a branch for a future release, but not released yet label Oct 4, 2020
@shadowspawn shadowspawn merged commit f15900d into tj:develop Oct 4, 2020
@shadowspawn shadowspawn deleted the feature/increase-coverage branch October 4, 2020 11:04
@shadowspawn shadowspawn removed the pending release Merged into a branch for a future release, but not released yet label Oct 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abetomo abetomo abetomo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shadowspawn @abetomo