Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs for chainable return type #1231

Merged
merged 1 commit into from Mar 30, 2020

Conversation

shadowspawn
Copy link
Collaborator

We had mixed descriptions for the return type of chainable routines. The TSDoc now has an actual return type of this which is not officially supported by the JSDoc, but that is still a useful way of referring to the return type in the text.

Consistently refer to returning "this command for chaining" in the JSDoc and TSDoc.

Copy link
Collaborator

@abetomo abetomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shadowspawn shadowspawn merged commit 8ec3e7f into tj:develop Mar 30, 2020
@shadowspawn shadowspawn deleted the feature/return-this-docs branch March 30, 2020 06:18
@shadowspawn shadowspawn added the pending release Merged into a branch for a future release, but not released yet label Apr 2, 2020
@shadowspawn shadowspawn removed the pending release Merged into a branch for a future release, but not released yet label Apr 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants