Explicitly require node 6 #1082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Related issue is #1045.
Problem
I was already suggested we only officially support from node 8, but concerned that people might be broken when we started using new features in later versions of Commander 4.x unless we enforced it from the start. However, it is relevant straight away! I used
classfor addition ofCommanderErrorwhich requires node 6.Solution
Specify that node 6 is required in
enginesfield ofpackage.jsonso user should hopefully get a warning when install if using an older versions of node. (There were bugs in some versions of npm which meant the warning is not displayed, fixed in npm 6.12.0 and higher.)