Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Changes are retrieved for everything since initial commit, instead of the current context like the GitHub UI #990

Closed
3 tasks done
hayescode opened this issue Feb 16, 2023 · 4 comments
Labels
bug Something isn't working

Comments

@hayescode
Copy link

hayescode commented Feb 16, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Does this issue exist in the latest version?

  • I'm using the latest release

Describe the bug?

I have an Action configured that runs when a PR is merged into Main. If my PR (1) was submitted before another PR (2), and the other PR (2) is merged 1st, this github action returns the changes from both PRs (1 and 2). I only want the changes from the PR that is running that action (1 in this example).

      - name: Get changed files
        id: changed-files
        uses: tj-actions/changed-files@v35.4.1
        with:
          separator: ","
          quotepath: true

I would expect to see these files in the Action but instead, I see considerably more, with no apparent way to differentiate which changes originated from where so that I could filter them out.

image

To Reproduce

  1. Submit PR 1
  2. Submit PR 2
  3. Merge # into main branch
  4. Run changed-files on PR 1
  5. File changes from both 1 and 2 are included

What OS are you seeing the problem on?

ubuntu-latest or ubuntu-20.04

Expected behavior?

Only the changed files in the PR are pulled in. Like how the GitHub UI does it.

Relevant log output

Every file is change is pulled

Anything else?

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@hayescode hayescode added the bug Something isn't working label Feb 16, 2023
@github-actions
Copy link
Contributor

Thanks for reporting this issue, don't forget to star this project if you haven't already to help us reach a wider audience.

@hayescode hayescode changed the title [BUG] <title> [BUG] Changes are retrieved for everything since initial commit, instead of the current context like the GitHub UI Feb 16, 2023
@jackton1
Copy link
Member

@hayescode I’ll recommend upgrading to the latest version, let me know if the issue persists and I’ll reopen this issue

@jackton1 jackton1 closed this as not planned Won't fix, can't repro, duplicate, stale Feb 16, 2023
@hayescode
Copy link
Author

@jackton1 it's also happening on 35.5.5. Do I need to pull origin before running this action or something? It doesn't happen every time which make me think it's a bug.

@jackton1
Copy link
Member

jackton1 commented Feb 18, 2023

@hayescode Given the lack of context, I’ll suggest creating a public repository the replicates the issue you are seeing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants