Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Similar commit hashes detected: previous sha: abc123 is equivalent to the current sha: abc123 on PR merge #778

Closed
3 tasks done
robgutsopedra opened this issue Nov 7, 2022 · 3 comments · Fixed by #780
Labels
bug Something isn't working

Comments

@robgutsopedra
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Does this issue exist in the latest version?

  • I'm using the latest release

Describe the bug?

Using version v34 I didn't have any issues - I created a PR, merged it, and on the merge of the PR I used this action to verify some files, like this:

name: "Create issue"

on:
  pull_request:
    branches:
      - main
    types:
      - closed

jobs:
  create-issue:
    name: Initial comment on PR
    if: github.event.pull_request.merged == true
    runs-on: preemptible-runners
    permissions:
      contents: "read"
      id-token: "write"
    steps:
    - uses: actions/checkout@v3
      with:
        fetch-depth: 0

    - name: Get changed files
      id: changed-files
      uses: tj-actions/changed-files@v34

    ##Comprobar que solo haya UN fichero .md añadido
    - name: List all added files and some info
      id: file_content
      run: |
        aux=0
        for file in ${{ steps.changed-files.outputs.added_files }}; do
          echo "$file was added"
          if [[ $file =~ \.md$ ]]; then
            rfc_file=$file
            echo "rfc_file=$file" >> $GITHUB_ENV
            aux=$(($aux+1))
          fi
        done

As of this morning, it started to fail due to:

image

I tried several options as per the docs, issues, comments... But nothing worked.

To fix it, I downgraded the version to 34.0.0 and everything went back to normal.
I'm assuming with the release that happened some hours ago, something stopped working/I'm missing something/I was doing something luckily right that has been fixed.

I'd love to know more about this issue!

I'm using self-hosted runners - Ubuntu 20

To Reproduce

  1. IMPORTANT - it only fails when merging the PR, not with pushes or when opening a PR
  2. Use version v34 or v34.3.0 in the workflow
  3. Open a new PR (in my case I was adding a new file)
  4. Merge the PR (I tried with and without squased, same error)

What OS are you seeing the problem on?

ubuntu-latest or ubuntu-20.04

Expected behavior?

I'd expect the minor update to keep working as before

Relevant log output

No response

Anything else?

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@robgutsopedra robgutsopedra added the bug Something isn't working label Nov 7, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2022

Thanks for reporting this issue, don't forget to star this project if you haven't already to help us reach a wider audience.

This was linked to pull requests Nov 7, 2022
This was unlinked from pull requests Nov 7, 2022
@jackton1 jackton1 linked a pull request Nov 7, 2022 that will close this issue
@jackton1
Copy link
Member

jackton1 commented Nov 7, 2022

Hi @robgutsopedra, this should be resolved in the latest release.

@robgutsopedra
Copy link
Author

I confirm it's working as expected again, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants