Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] <title> #660

Closed
3 tasks done
aseem-heg opened this issue Sep 30, 2022 · 3 comments
Closed
3 tasks done

[BUG] <title> #660

aseem-heg opened this issue Sep 30, 2022 · 3 comments
Labels
bug Something isn't working duplicate This issue or pull request already exists

Comments

@aseem-heg
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Does this issue exist in the latest version?

  • I'm using the latest release

Describe the bug?

I deploy branch1 to master, then immediately deploy branch2 to master.
Both deployments have GHA functionality where they check for file changes using this GHA changed-files functionality.
I have set fetch-depth: 0

Observations:

  • This runs fine when just 1 branch is deployed to master at a time.
  • When I rerun failed job manually - it fails again consistently.
  • this library is trying to get changed file names between
    • Pushed commit: commit that triggered this workflow on gha
    • 2nd commit from head of the branch.
  • Since I immediately push another commit to dev branch before this first commits workflow to check file-changed starts - we see that both SHA are same for git diff
    • git diff commit_2 commit_2

Hence we get this error.

To Reproduce

Create branch1 from master.
Then create branch2 from master.
Add some unique changes to both branches.
Write some GHA code job as below:

jobs:
  seed_data_changed:
    name: Check if seed data files changed
    runs-on: ubuntu-latest
    steps:
      - name: Checkout code
        uses: actions/checkout@v3
        with:
          fetch-depth: 0 # fetch all history of all branches

      - name: Get changed files
        id: changed-files
        uses: tj-actions/changed-files@v31

What OS are you seeing the problem on?

ubuntu-latest or ubuntu-20.04

Expected behavior?

No error should be shown.
We should see file changes as usual.

Relevant log output

No response

Anything else?

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@aseem-heg aseem-heg added the bug Something isn't working label Sep 30, 2022
@jackton1
Copy link
Member

Hi @aseem-heg Can you include the full logs output with debugging enabled to help resolve this issue faster?

@jackton1 jackton1 closed this as not planned Won't fix, can't repro, duplicate, stale Oct 2, 2022
@aseem-heg
Copy link
Author

Why are you closing the issue?

@jackton1
Copy link
Member

jackton1 commented Oct 3, 2022

@aseem-heg I think this issue is a duplicate of #668 which is a known bug that should be resolved soon.

@jackton1 jackton1 added the duplicate This issue or pull request already exists label Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants