Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] I'd like to use file name consisting of Korean, not English #658

Closed
3 tasks done
corhythm opened this issue Sep 29, 2022 · 2 comments · Fixed by #659
Closed
3 tasks done

[BUG] I'd like to use file name consisting of Korean, not English #658

corhythm opened this issue Sep 29, 2022 · 2 comments · Fixed by #659
Labels
bug Something isn't working

Comments

@corhythm
Copy link

corhythm commented Sep 29, 2022

Is there an existing issue for this?

  • I have searched the existing issues

Does this issue exist in the latest version?

  • I'm using the latest release

Describe the bug?

I use the file name in Korean. but in all_changed_files, The change is not detected.
if I use the file name in english is works. Is it possible to use the file name in Korean?

To Reproduce

  • A change occurred in the file consisting of Korean name.
  • Run tj-actions/changed-files on the branch, example workflow
name: Tistory auto upload

on:
  push:
    paths:
      - "post/**"
    branches: [ "main" ]
  pull_request:
    branches: [ "main" ]

permissions:
  contents: read

jobs:
  auto-upload-process:
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v3  # {소유자}/{저장소명}@{참조자}
        with:
          persist-credentials: false # otherwise, the token used is the GITHUB_TOKEN, instead of your personal access token.
          fetch-depth: 0 # 과거 변경 이력 가져오기. 기본값(1), 전체 가져오기(0)
      - name: Get changed files
        id: changed-files
        uses: tj-actions/changed-files@v31
        with:
          files: | # **/*.md랑 *.md랑 다름. *.md 하면 인식 못함
            **/*.md
          files_ignore: |
            **/*.yml
            **/*.py
      - name: List all any changed files
        run: |
          echo "changed_files=${{ steps.changed-files.outputs.all_changed_files }}"
      - name: Set up Python 3.10
        uses: actions/setup-python@v3
        with:
          python-version: "3.10"
      - name: Cache pip dependencies
        uses: actions/cache@v3
        with:
          path: ~/.cache/pip
          key: ${{ hashFiles('setup.py') }}-${{ hashFiles('requirements.txt') }}
      - name: Install dependencies
        run: |
          python -m pip install --upgrade pip
          if [ -f requirements.txt ]; then pip install -r requirements.txt; fi
      - name: Write or modify tistory post
        env:
          REPO_NAME: ${{ secrets.REPO_NAME }}
          REPO_ACCESS_TOKEN: ${{ secrets.REPO_ACCESS_TOKEN }}
          FULL_ACCESS_GITHUB_TOKEN: ${{ secrets.FULL_ACCESS_GITHUB_TOKEN }}
          BASE_URL: ${{ secrets.BASE_URL }}
          TISTORY_ACCESS_TOKEN: ${{ secrets.TISTORY_ACCESS_TOKEN }}
          BLOG_NAME: ${{ secrets.BLOG_NAME }}
        run: |
          python3 main.py --changed ${{ steps.changed-files.outputs.all_changed_files }}

What OS are you seeing the problem on?

ubuntu-latest or ubuntu-20.04

Expected behavior?

If there is a change in the file consisting of Korean name, this action detect changes.

Relevant log output

No response

Anything else?

Thank you for the good service.

Code of Conduct

  • I agree to follow this project's Code of Conduct
@corhythm corhythm added the bug Something isn't working label Sep 29, 2022
@jackton1
Copy link
Member

jackton1 commented Sep 29, 2022

@corhythm I believe you can use quotepath: "false". See: https://github.com/tj-actions/changed-files#inputs for more information.

An example with non ASCII characters

Screen Shot 2022-09-29 at 12 16 58 PM

@corhythm
Copy link
Author

corhythm commented Oct 4, 2022

@jackton1 Oh, it works! Thank you for helping me and I'm sorry I didn't read the manual properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants