Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relative path from a working directory #657

Closed
3 tasks done
okbel opened this issue Sep 29, 2022 · 2 comments
Closed
3 tasks done

Relative path from a working directory #657

okbel opened this issue Sep 29, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@okbel
Copy link

okbel commented Sep 29, 2022

Is there an existing issue for this?

  • I have searched the existing issues

Does this issue exist in the latest version?

  • I'm using the latest release

Describe the bug?

Hello!

diff_relative this directive is not returning the relative path from the folder I'm in.

    with:
      diff_relative: "true"
      files: |
        web/**

returns paths with web prefixed. Is this expected?

Apologies if I misunderstood the functionality of diff_relative. I've also tried using a boolean, non-string like value. (true) I couldn't find the example to get the relative path within a specific folder.

Thank you!

To Reproduce

Running this part within a GH action

    with:
      diff_relative: "true"
      files: |
        web/**

What OS are you seeing the problem on?

macos-11

Expected behavior?

To return paths only relative to the working folder.

Relevant log output

No response

Anything else?

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@okbel okbel added the bug Something isn't working label Sep 29, 2022
@jackton1
Copy link
Member

jackton1 commented Sep 29, 2022

Hi @okbel it appears the docs needed some improvement, I’ve highlighted that you need to specify the top level directory you’ll like to use via the path input.

In your case that would be

    with:
      diff_relative: "true"
      path: web
      files: ”**”

If the intent is to change the working directory.

Note: That the patterns would match files located within the current working directory.

@okbel
Copy link
Author

okbel commented Sep 30, 2022

Thank you so much @jackton1 🙏 Much appreciation for your work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants